fix: judge file server changed #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyuuttaaoo
approved these changes
Dec 17, 2024
messixukejia
requested changes
Dec 17, 2024
| bool PipelineManager::CheckIfFileServerUpdated(const Json::Value& config) { | ||
| string inputType = config["Type"].asString(); | ||
| return inputType == "input_file" || inputType == "input_container_stdio"; | ||
| bool PipelineManager::CheckIfFileServerUpdated(PipelineConfigDiff& diff) { |
There was a problem hiding this comment.
既然已经出现了之前测试不到的情况，是不是应该针对性的补充用例？
| } | ||
| } | ||
| for (const auto& config : diff.mModified) { | ||
| string inputType = (*config.mInputs[0])["Type"].asString(); |
There was a problem hiding this comment.
load配置的地方是否能够保证[0]的合法性？
There was a problem hiding this comment.
前面配置解析会检验input至少包含一个，保证这里加载流水线一定是合法的
henryzhx8
approved these changes
Dec 18, 2024
messixukejia
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题
在多个配置加载时，需要根据input_file判断isFileServerInputChanged，从而决定是否启动FileServer。但是之前PR修改，导致后一个配置的结果可以覆盖前一个配置。
修复
任意一个配置改变了input_file，isFileServerInputChanged都应该是true