fix: unittest fail in enterprise mode #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Abingcbc
commented
Dec 19, 2024
Abingcbc
commented
- APSARA_UNIT_TEST_MAIN设置位置不对，导致编译unittest_base的时候部分代码识别不到这个宏
- 注释部分enterprise跑不通的单测
messixukejia
approved these changes
Dec 19, 2024
yyuuttaaoo
reviewed
Dec 23, 2024
| @@ -77,6 +77,7 @@ if (UNIX) | |||
| SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fprofile-arcs -ftest-coverage") | |||
| SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fprofile-arcs -ftest-coverage") | |||
| SET(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fprofile-arcs -ftest-coverage") | |||
| add_definitions(-DAPSARA_UNIT_TEST_MAIN) | |||
There was a problem hiding this comment.
如果同是编译binary和ut，binary会有问题
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.