Small enhancements to makefile and nr-binder permission #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new clean function can be called by executing `make clean` It is useful if a rebuild from scratch is necessary (e.g. when developing a new feature and testing its build process, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR updates the nr-binder execution permissions (so it's ready to use after clone/build) and creates a
cleanfunction to UERANSIM's makefile.I was in doubt if moving the
rm -fr logscommand to this function then calling it automatically at every build would be desirable, so I left it untouched for now and just added the clean to be used bymake clean. If this is ok, feel free to just ping me here so I can update this PR.This PR also solves the issues reported on #721 and #724. So, it closes #721 and closes #724
TIA,
Leo.