Allow Line Feed & Carriage Return as safe chars

resolves: QubesOS/qubes-issues#5701
alimirjamali · Aug 31, 2024 · 50ccbfc · 50ccbfc
1 parent 2a9664f
commit 50ccbfc
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/qubesusbproxy/core3ext.py b/qubesusbproxy/core3ext.py
@@ -642,9 +642,10 @@ async def on_device_attach_usb(self, vm, event, device, options):
                 else:
                     # TODO: sanitize and include stdout
                     sanitized_stderr = ''.join(
-                        [chr(c) for c in e.stderr if 0x20 <= c < 0x80])
+                        [chr(c) for c in e.stderr if 0x20 <= c < 0x80
+                         or c in [0x0A, 0x0D]])
                     raise QubesUSBException(
-                        'Device attach failed: {}'.format(sanitized_stderr))
+                        'Device attach failed:\n{}'.format(sanitized_stderr))
         finally:
             modify_qrexec_policy('qubes.USB+{}'.format(device.ident),
                 policy_line, False)