Allow Line Feed & Carriage Return as safe chars

resolves: QubesOS/qubes-issues#5701
alimirjamali · Sep 27, 2024 · 866047e · 866047e
1 parent 2a9664f
commit 866047e
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/qubesusbproxy/core3ext.py b/qubesusbproxy/core3ext.py
@@ -641,8 +641,11 @@ async def on_device_attach_usb(self, vm, event, device, options):
                         "qubes-usb-proxy not installed in the VM")
                 else:
                     # TODO: sanitize and include stdout
+                    sanitized_stderr = e.stderr.replace("\n", ", ")
                     sanitized_stderr = ''.join(
-                        [chr(c) for c in e.stderr if 0x20 <= c < 0x80])
+                        [chr(c) for c in sanitized_stderr if 0x20 <= c < 0x80])
+                    if sanitized_stderr.endswith(", "):
+                        sanitized_stderr = santizied_stderr[:-2] + "."
                     raise QubesUSBException(
                         'Device attach failed: {}'.format(sanitized_stderr))
         finally: