Skip to content

Commit

Permalink
Distinguish between unpacking tarball and compiling
Browse files Browse the repository at this point in the history
Make it obvious to the user whether we're actually compiling a package or just
unpacking a prebuilt tarball.
  • Loading branch information
TimoWilken committed Feb 28, 2024
1 parent 496b61e commit 075e99c
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions alibuild_helpers/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -1010,9 +1010,6 @@ def doBuild(args, parser):
"runtime_requires": " ".join(spec["runtime_requires"]),
})

banner("Building %s@%s", spec["package"],
args.develPrefix if "develPrefix" in args and spec["package"] in develPkgs
else spec["version"])
# Define the environment so that it can be passed up to the
# actual build script
buildEnvironment = [
Expand Down Expand Up @@ -1076,9 +1073,12 @@ def doBuild(args, parser):
build_command = "%s -e -x %s/build.sh 2>&1" % (BASH, quote(scriptDir))

debug("Build command: %s", build_command)
progress = ProgressPrint("%s is being built (use --debug for full output)" % spec["package"])
err = execute(build_command, printer=debug if args.debug or not sys.stdout.isatty() else progress)
progress.end("failed" if err else "ok", err)
progress = ProgressPrint("%s %s@%s (use --debug for full output)" % (

Check warning on line 1076 in alibuild_helpers/build.py

View check run for this annotation

Codecov / codecov/patch

alibuild_helpers/build.py#L1076

Added line #L1076 was not covered by tests
"Unpacking tarball for" if cachedTarball else "Compiling", spec["package"],
args.develPrefix if "develPrefix" in args and spec["is_devel_pkg"] else spec["version"],
))
err = execute(build_command, printer=progress)
progress.end("failed" if err else "done", err)
report_event("BuildError" if err else "BuildSuccess", spec["package"], " ".join((

Check warning on line 1082 in alibuild_helpers/build.py

View check run for this annotation

Codecov / codecov/patch

alibuild_helpers/build.py#L1080-L1082

Added lines #L1080 - L1082 were not covered by tests
args.architecture,
spec["version"],
Expand Down

0 comments on commit 075e99c

Please sign in to comment.