Ensure spec["version"] is a string before trying to expand it #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some valid versions defined in the recipe can be parsed as floats instead (e.g. 1.0) Fix by @mborisyak Further discussion here: ShipSoft/shipdist#94
ktf
reviewed
Nov 20, 2024
| @@ -123,7 +123,7 @@ def resolve_version(spec, defaults, branch_basename, branch_stream): | |||
| defaults_upper = defaults != "release" and "_" + defaults.upper().replace("-", "_") or "" | |||
| commit_hash = spec.get("commit_hash", "hash_unknown") | |||
| tag = str(spec.get("tag", "tag_unknown")) | |||
| return spec["version"] % { | |||
There was a problem hiding this comment.
I am not sure this will work correctly. For example the float 1.00 which might be intended as the version "1.00" will happily convert to "1.0". If you really want to fix this, it needs to be done at the level of the parser which should always consider "version" to be followed by a string.
ktf
requested changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some valid versions defined in the recipe can be parsed as floats
instead (e.g. 1.0)
Fix by @mborisyak
Closes #887
Further discussion here: ShipSoft/shipdist#94