Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mossbauer graphs #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

asudhakar-umass
Copy link

Added code for plotting independent graphs of samples for mossbauer - not ready for production push

Copy link
Member

@perimosocordiae perimosocordiae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start! I haven't tested it out yet, just read through the code.

@@ -9,6 +9,7 @@ var Plot = (function() {

return {
plot: function(btn) {
var is_fig_indp = btn.id=="ind_plot_button" ? true : false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems easier to add this as a parameter to this method, and pass the boolean in the inline JS code in _filterplots.js.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, if you merge the plot buttons back into one, you can get this information in the GetArgs.plot(...) function.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha ha 👍 that's one way of doing it too :) I am removing the second button... I m putting it as one of the options.

</td></tr>
<tr><td colspan=3>
<button id="ind_plot_button" class="needs_filter wide_button" onclick="Plot.plot(this);" disabled>
Plot Separately<span class='wait'>Waiting...</span></button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer keeping one "Plot" button and having the separated plot option be specified with the rest of the options.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with Darby on this and showed her a small demo. She was ok... but I see why you you would like a single plot button. I m going to put a checkbox in place to make it look cleaner. And send it over to Darby with one plot button and see what she thinks...

@@ -8,6 +8,7 @@
from matplotlib import rcParams
from matplotlib.collections import LineCollection
from matplotlib.gridspec import GridSpec
from matplotlib import pyplot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this import needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry... forgot to clean-up!

@perimosocordiae
Copy link
Member

Oh, and it looks like you changed the permissions of some files. Can you change them back to 0644?

@asudhakar-umass
Copy link
Author

Oh, and it looks like you changed the permissions of some files. Can you change them back to 0644?
-- I am not sure I understand this... I dont recall changing permissions, I might have unintentionally...

<button id="plot_button" class="needs_filter" onclick="Plot.plot(this);" disabled>
Plot<span class='wait'>ting...</span></button>
<button id="plot_button" class="needs_filter wide_button" onclick="Plot.plot(this);" disabled>
Plot<span class='wait'>Waiting...</span></button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes to the plot button and the CSS changes aren't needed anymore.

@perimosocordiae
Copy link
Member

If you look at the "Files changed" tab on the pull request page, you'll see a bunch of "100644 → 100755" next to the filenames. That means the file permissions were changed. If you're using OSX or Linux, you can change them back with chmod. I'm not sure how to change it from Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants