Expired reason iota fix #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EntryStatus back to the caller "Expired" cannot be differentiated. Fixing this by default "_" to 0 and incremental RemoveReasons comment was missing for GetWithInfo api so updated that test: ran all unit test cases
|
rebasing #181 to versions/v3-prep |
Codecov Report
@@ Coverage Diff @@
## versions/v3-prep #255 +/- ##
====================================================
+ Coverage 86.56% 87.01% +0.45%
====================================================
Files 15 15
Lines 640 647 +7
====================================================
+ Hits 554 563 +9
+ Misses 71 68 -3
- Partials 15 16 +1
Continue to review full report at Codecov.
|
|
What exactly does it fix? Can you provide a failing test that is fixed by this change? |
Currently all const for RemovedReason are explicitly set to avoid any breaking changes. For v3 migrating the reasons to iota makes code readability and managing addition of more reasons easier in the future. Test: Validated all test cases run successfully.
janisz
approved these changes
Nov 18, 2020
|
@mxplusb will this make cut for v3 ? |
cristaloleg
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.