remove unused error message

allegro · Aug 14, 2024 · bd0e569 · bd0e569
1 parent ad322ff
commit bd0e569
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 23 deletions.
diff --git a/hermes-console/src/composables/sync/use-sync/useSync.spec.ts b/hermes-console/src/composables/sync/use-sync/useSync.spec.ts
@@ -47,7 +47,7 @@ describe('useSync', () => {
     await waitFor(() => {
       expectNotificationDispatched(notificationStore, {
         type: 'error',
-        title: 'notifications.sync.failure',
+        title: 'notifications.consistency.sync.failure',
       });
     });
   });
@@ -70,7 +70,7 @@ describe('useSync', () => {
     await waitFor(() => {
       expectNotificationDispatched(notificationStore, {
         type: 'error',
-        title: 'notifications.sync.failure',
+        title: 'notifications.consistency.sync.failure',
       });
     });
   });
@@ -96,7 +96,7 @@ describe('useSync', () => {
     await waitFor(() => {
       expectNotificationDispatched(notificationStore, {
         type: 'error',
-        title: 'notifications.sync.failure',
+        title: 'notifications.consistency.sync.failure',
       });
     });
   });
@@ -119,7 +119,7 @@ describe('useSync', () => {
     await waitFor(() => {
       expectNotificationDispatched(notificationStore, {
         type: 'success',
-        text: 'notifications.sync.success',
+        text: 'notifications.consistency.sync.success',
       });
     });
   });
@@ -142,7 +142,7 @@ describe('useSync', () => {
     await waitFor(() => {
       expectNotificationDispatched(notificationStore, {
         type: 'success',
-        text: 'notifications.sync.success',
+        text: 'notifications.consistency.sync.success',
       });
     });
   });
@@ -168,7 +168,7 @@ describe('useSync', () => {
     await waitFor(() => {
       expectNotificationDispatched(notificationStore, {
         type: 'success',
-        text: 'notifications.sync.success',
+        text: 'notifications.consistency.sync.success',
       });
     });
   });

diff --git a/hermes-console/src/composables/sync/use-sync/useSync.ts b/hermes-console/src/composables/sync/use-sync/useSync.ts
@@ -5,13 +5,11 @@ import {
   syncTopic as doSyncTopic,
 } from '@/api/hermes-client';
 import { groupName } from '@/utils/topic-utils/topic-utils';
-import { ref, type Ref } from 'vue';
 import { useConsistencyStore } from '@/store/consistency/useConsistencyStore';
 import { useGlobalI18n } from '@/i18n';
 import { useNotificationsStore } from '@/store/app-notifications/useAppNotifications';
 
 export interface UseSync {
-  errorMessage: Ref<Error | null | undefined>;
   syncGroup: (groupName: string, primaryDatacenter: string) => Promise<boolean>;
   syncTopic: (
     topicQualifiedName: string,
@@ -25,28 +23,25 @@ export interface UseSync {
 }
 
 export function useSync(): UseSync {
-  const errorMessage: Ref<Error | null | undefined> = ref();
-
   const notificationStore = useNotificationsStore();
   const consistencyStore = useConsistencyStore();
 
   const syncGroup = async (groupName: string, primaryDatacenter: string) => {
     try {
       await doSyncGroup(groupName, primaryDatacenter);
       await notificationStore.dispatchNotification({
-        text: useGlobalI18n().t('notifications.sync.success', {
+        text: useGlobalI18n().t('notifications.consistency.sync.success', {
           group: groupName,
         }),
         type: 'success',
       });
       await consistencyStore.refresh(groupName);
       return true;
     } catch (e: any) {
-      errorMessage.value = e as Error;
       dispatchErrorNotification(
         e,
         notificationStore,
-        useGlobalI18n().t('notifications.sync.failure', {
+        useGlobalI18n().t('notifications.consistency.sync.failure', {
           group: groupName,
         }),
       );
@@ -62,19 +57,18 @@ export function useSync(): UseSync {
     try {
       await doSyncTopic(topicQualifiedName, primaryDatacenter);
       await notificationStore.dispatchNotification({
-        text: useGlobalI18n().t('notifications.sync.success', {
+        text: useGlobalI18n().t('notifications.consistency.sync.success', {
           group,
         }),
         type: 'success',
       });
       await consistencyStore.refresh(group);
       return true;
     } catch (e: any) {
-      errorMessage.value = e as Error;
       dispatchErrorNotification(
         e,
         notificationStore,
-        useGlobalI18n().t('notifications.sync.failure', {
+        useGlobalI18n().t('notifications.consistency.sync.failure', {
           group,
         }),
       );
@@ -95,19 +89,18 @@ export function useSync(): UseSync {
         primaryDatacenter,
       );
       await notificationStore.dispatchNotification({
-        text: useGlobalI18n().t('notifications.sync.success', {
+        text: useGlobalI18n().t('notifications.consistency.sync.success', {
           group,
         }),
         type: 'success',
       });
       await consistencyStore.refresh(group);
       return true;
     } catch (e: any) {
-      errorMessage.value = e as Error;
       dispatchErrorNotification(
         e,
         notificationStore,
-        useGlobalI18n().t('notifications.sync.failure', {
+        useGlobalI18n().t('notifications.consistency.sync.failure', {
           group,
         }),
       );
@@ -116,7 +109,6 @@ export function useSync(): UseSync {
   };
 
   return {
-    errorMessage,
     syncGroup,
     syncSubscription,
     syncTopic,

diff --git a/hermes-console/src/i18n/en-US/index.ts b/hermes-console/src/i18n/en-US/index.ts
@@ -708,9 +708,11 @@ const en_US = {
         failure: "Couldn't delete topic {topic}",
       },
     },
-    sync: {
-      success: 'Synchronization of {group} succeeded',
-      failure: 'Synchronization of {group} failed',
+    consistency: {
+      sync: {
+        success: 'Synchronization of {group} succeeded',
+        failure: 'Synchronization of {group} failed',
+      },
     },
     subscription: {
       create: {