Spring boot 3 #1680
Spring boot 3 #1680
Conversation
There was a problem hiding this comment.
Great effort @moscicky! 🥳 Very clean and smooth PR considering amount of changes required after Spring Boot upgrade.
| /** | ||
| * RestTemplateHermesSender. | ||
| * | ||
| * @deprecated as of Hermes 2.2.10, in favor of {@link pl.allegro.tech.hermes.client.webclient.WebClientHermesSender} |
There was a problem hiding this comment.
question: I guess that we want to remove support for RestTemplateHermesSender because we have a nice occasion for doing that by upgrading Hermes to new Spring Boot, right?
Or it was impossible to keep support for RestTemplateHermesSender with newer Spring? I'm asking because not so long ago we had a discussion about RestTemplateHermesSender.
There was a problem hiding this comment.
is it impossible to keep support for RestTemplateHermesSender with newer Spring?
Yes. RestTemplateHermesSender should have actually been called AsyncRestTemplateHermesSender because it was using AsyncRestTemplateHermesSender underneath. AsyncRestTemplate was removed in spring boot 3. In theory we could switch to using regular RestTemplate underneath but HermesSender is inherently asynchronous:
public interface HermesSender {
CompletableFuture<HermesResponse> send(URI uri, HermesMessage message);
}and RestTemplate is sync. Imo its best to remove RestTemplateHermesSender and encoure clients to migrate to WebClientSender
| @@ -34,6 +34,9 @@ dependencies { | |||
| implementation group: 'com.jayway.jsonpath', name: 'json-path', version: '2.5.0' | |||
| implementation group: 'com.fasterxml.jackson.datatype', name: 'jackson-datatype-jsr310', version: versions.jackson | |||
|
|
|||
| //TODO: remove after migrating from apache oltu | |||
There was a problem hiding this comment.
suggestion: Can we create an issue for migrating from Apache Oltu to other solution?
Maybe someone from Open Source community would be interested :)
There was a problem hiding this comment.
it's already created :), see: #1679
...tion/src/integration/java/pl/allegro/tech/hermes/frontend/KafkaNamesMapperConfiguration.java
Outdated
Show resolved
Hide resolved
- except apache oltu related code
This PR:
spring bootto 3.x.xjava eetojakartanamespace (with the exception of jms related code)jetty9 -> 11 (11 supportsjakartanamespace, also required bywiremock 3.x)wiremockto version 3.beta which supportsjakartanamespacehermes-clientwithreactorAPI changes: hermes-client is incompatible with Reactor 3.5 #1671AsyncRestTemplateinhermes-client