do not remove subscription if it already existed before subscription creation #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitagoras3
reviewed
Aug 5, 2024
...va/pl/allegro/tech/hermes/management/domain/topic/commands/CreateTopicRepositoryCommand.java
Show resolved
Hide resolved
pitagoras3
previously approved these changes
Aug 5, 2024
faderskd
approved these changes
Aug 6, 2024
pitagoras3
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes rollbacks of multi dc commands to be exception aware and changes
CreateSubscriptionRepositoryCommandso that subscription is not removed if it already existed before.That could happen if two subscription creation requests are made concurrently so that both requests are marked as valid, one creates subscription in storage and the other fails and performs rollback which causes the subscription to be removed.
In multi DC setup, this would result in inconsistent state:
dc 1 -> null
dc 2 -> susbscription