Synchronize zookeeper clusters with UI #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szczygiel-m
reviewed
Aug 13, 2024
| await waitFor(() => { | ||
| expectNotificationDispatched(notificationStore, { | ||
| type: 'error', | ||
| title: 'notifications.sync.failure', |
There was a problem hiding this comment.
minor: what do You think about changing its path to "notifications.consistency.sync.failure"? maybe it will be more readable
| import { useNotificationsStore } from '@/store/app-notifications/useAppNotifications'; | ||
|
|
||
| export interface UseSync { | ||
| errorMessage: Ref<Error | null | undefined>; |
There was a problem hiding this comment.
why can it be undefined?
There was a problem hiding this comment.
actually the errorMessage was not consumed anywhere, removed it entirely
| import static pl.allegro.tech.hermes.test.helper.builder.SubscriptionBuilder.subscriptionWithRandomName | ||
| import static pl.allegro.tech.hermes.test.helper.builder.TopicBuilder.randomTopic | ||
|
|
||
| class StorageSyncSpec extends MultiZookeeperIntegrationTest { |
szczygiel-m
previously approved these changes
Aug 21, 2024
szczygiel-m
approved these changes
Aug 21, 2024
faderskd
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow admins to perform storage synchronization using UI. Admin selects "primary" DC for group/topic/subscription and its content is propagated to nodes in other DCs.
After synchronization only the group that was synchronized is refreshed so consistency view shows up to date information without making an expensive check for all groups
