Skip to content

Commit

Permalink
Add cached-path clients in prepare_cli_environment()
Browse files Browse the repository at this point in the history
  • Loading branch information
epwalsh committed Oct 9, 2024
1 parent fce368a commit a032acf
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- `BeakerLaunchConfig.setup_steps` should now include steps to clone your repo (which it will by default). This change allows support for private repos.

### Fixed

- `prepare_cli_environment()` now calls `add_cached_path_clients()`.

## [v1.4.0](https://github.com/allenai/OLMo-core/releases/tag/v1.4.0) - 2024-10-02

### Changed
Expand Down
4 changes: 4 additions & 0 deletions src/olmo_core/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,7 @@ def prepare_cli_environment(log_filter_type: Optional[LogFilterType] = None):
- :func:`install_excepthook()`
- :func:`filter_warnings()`
- :func:`set_env_variables()`
- :func:`~olmo_core.io.add_cached_path_clients()`
.. tip::
If you're looking to setup the environment specifically for distributed training,
Expand All @@ -417,13 +418,16 @@ def prepare_cli_environment(log_filter_type: Optional[LogFilterType] = None):
.. note::
All ranks will always emit messages at the ``WARNING`` level or higher.
"""
from .io import add_cached_path_clients

if log_filter_type is None:
log_filter_type = LogFilterType(os.environ.get(LOG_FILTER_TYPE_ENV_VAR, "rank0_only"))
rich.reconfigure(width=max(rich.get_console().width, 180), soft_wrap=True)
setup_logging(log_filter_type=log_filter_type)
install_excepthook()
filter_warnings()
set_env_variables()
add_cached_path_clients()


class _RichHandler(logging.Handler):
Expand Down

0 comments on commit a032acf

Please sign in to comment.