Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds wapo/v4 support #277

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Adds wapo/v4 support #277

merged 4 commits into from
Nov 15, 2024
+16 −8

Conversation

andreaschari
Copy link
Contributor

No description provided.

@seanmacavaney
Copy link
Collaborator

It doesn't look like the tests are added? I see self._build_test_docs('wapo/v4') in the test file; the output of this generated sample should be checked and added to the file.

seanmacavaney
seanmacavaney requested changes Nov 15, 2024
View reviewed changes
test/integration/wapo.py Outdated Show resolved Hide resolved
@seanmacavaney
Copy link
Collaborator

Thanks, I think we're all set!

@seanmacavaney seanmacavaney merged commit a42286e into allenai:master Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmacavaney seanmacavaney Awaiting requested review from seanmacavaney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaschari @seanmacavaney