fix lint error

allenai · Sep 18, 2023 · 6563ac7 · 6563ac7
1 parent 01077eb
commit 6563ac7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tango/common/from_params.py b/tango/common/from_params.py
@@ -514,7 +514,7 @@ def construct_arg(
             )
     elif annotation == str:
         # Strings are special because we allow casting from Path to str.
-        if type(popped_params) == str or isinstance(popped_params, Path):
+        if isinstance(popped_params, str) or isinstance(popped_params, Path):
             return str(popped_params)  # type: ignore
         else:
             raise TypeError(

diff --git a/tests/common/from_params_test.py b/tests/common/from_params_test.py
@@ -470,7 +470,7 @@ def __init__(self, a: str, x: int = 42, **kwargs):
         assert instance.x == 42
         assert instance.a == -1
         assert len(instance.rest) == 1  # type: ignore
-        assert type(instance.rest["raw_a"]) == str  # type: ignore
+        assert isinstance(instance.rest["raw_a"], str)  # type: ignore
         assert instance.rest["raw_a"] == "123"  # type: ignore
 
     def test_kwargs_are_passed_to_deeper_superclasses(self):