Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vtimezone tzinfo implementation #94

Merged
merged 4 commits into from
Aug 27, 2022
Merged

Add vtimezone tzinfo implementation #94

merged 4 commits into from
Aug 27, 2022

Conversation

allenporter
Copy link
Owner

@allenporter allenporter commented Aug 27, 2022

Add vtimezone tzinfo implementation with the following changes:

  • Evaluate rrules for vtimezones
  • centralize rrule creation and iterator libraries for rrule evaluation in multiple contexts beyond timeline
  • add dtstart and rrule validation based on rfc5545

This change allows you to create datetime objects with a functioning timezone based on the ics input, however currently it is currently not yet used when parsing an ICS file.

Issue #70
Issue #71

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2022

Codecov Report

Merging #94 (53f4b6f) into main (0943cbe) will increase coverage by 0.16%.
The diff coverage is 96.98%.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   96.59%   96.76%   +0.16%     
==========================================
  Files          20       21       +1     
  Lines        1791     1885      +94     
==========================================
+ Hits         1730     1824      +94     
  Misses         61       61              
Impacted Files Coverage Δ
ical/calendar.py 100.00% <ø> (ø)
ical/timezone.py 96.42% <94.59%> (-2.21%) ⬇️
ical/types.py 96.70% <95.23%> (-0.06%) ⬇️
ical/event.py 96.18% <100.00%> (+0.02%) ⬆️
ical/iter.py 100.00% <100.00%> (ø)
ical/journal.py 100.00% <100.00%> (ø)
ical/timeline.py 95.40% <100.00%> (+1.83%) ⬆️
ical/todo.py 98.36% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@allenporter allenporter merged commit 386c98a into main Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants