Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fatal on channel read failure #1155

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

kevinfodness
Copy link
Member

  • Prevents a fatal on channel read failure and replaces it with an admin notice.
  • Clears the channel transient if settings are updated to allow users to fix bad API credentials and try again.
  • Selectively displays the success message on the settings screen based on whether the user has just submitted the form or not.

Fixes #1150

Copy link

@kingkool68 kingkool68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍎

@kevinfodness kevinfodness merged commit 29fd125 into develop Sep 3, 2024
8 checks passed
@kevinfodness kevinfodness deleted the fix/channel-read-fatal branch September 3, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal Error, latest version 2.5.0
2 participants