Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous updates #157

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Miscellaneous updates #157

merged 3 commits into from
Aug 25, 2023

Conversation

renatonascalves
Copy link
Contributor

@renatonascalves renatonascalves commented Aug 24, 2023

  • Removing import of React (not required since React 17)
  • Allow for components to be passed a custom input ID
  • Fix redux duplication registration when importing the storeCreator in a custom project
  • Pass the second param to useSelect to avoid unnecessary rerenders
  • Remove unnecessary $index from rest_hydrate_profiles
  • Misc changes

@renatonascalves renatonascalves self-assigned this Aug 24, 2023
import PropTypes from 'prop-types';
import Autocomplete from 'react-autocomplete';

// Hooks.
import { useDebounce } from '@uidotdev/usehooks';

const BylineAutocomplete = ({
id,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these components could benefit from a forwardRef. But I don't have a use case for it yet. 🤔

Copy link

@harlessmark harlessmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job 🙇🏻‍♂️

@renatonascalves renatonascalves merged commit d07da74 into production Aug 25, 2023
8 checks passed
@renatonascalves renatonascalves deleted the feature/misc-changes branch August 25, 2023 15:19
alley-ci pushed a commit that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants