Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGM Allele Associations - SCRUM 4668 #1793

Open
wants to merge 10 commits into
base: alpha
Choose a base branch
from
Open

AGM Allele Associations - SCRUM 4668 #1793

wants to merge 10 commits into from

Conversation

VarunReddy1111
Copy link
Contributor

No description provided.

markquintontulloch
markquintontulloch requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@markquintontulloch markquintontulloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few changes required

...e/curation_api/jobs/executors/associations/agmAssociations/AgmAlleleAssociationExecutor.java Outdated Show resolved Hide resolved
...ncegenome/curation_api/model/entities/associations/agmAssociations/AgmAlleleAssociation.java Outdated Show resolved Hide resolved
...ncegenome/curation_api/model/entities/associations/agmAssociations/AgmAlleleAssociation.java Outdated Show resolved Hide resolved
...cegenome/curation_api/services/associations/agmAssociations/AgmAlleleAssociationService.java Outdated Show resolved Hide resolved
...i/services/validation/dto/associations/agmAssociations/AgmAlleleAssociationDTOValidator.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markquintontulloch markquintontulloch markquintontulloch requested changes

@oblodgett oblodgett Awaiting requested review from oblodgett

@adamgibs adamgibs Awaiting requested review from adamgibs

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VarunReddy1111 @markquintontulloch