Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tabs for proposal page #31

Merged
merged 3 commits into from
Mar 19, 2024
Merged

feat: tabs for proposal page #31

merged 3 commits into from
Mar 19, 2024

Conversation

Stuyk
Copy link
Collaborator

@Stuyk Stuyk commented Mar 15, 2024

Tabs for proposal page. Uses a simple v-model for setting / getting current tab.

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for govgen-governance-dapp ready!

Name Link
🔨 Latest commit f6bfc61
🔍 Latest deploy log https://app.netlify.com/sites/govgen-governance-dapp/deploys/65f84ca6b6aa6e0008a7cb8c
😎 Deploy Preview https://deploy-preview-31--govgen-governance-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Stuyk Stuyk marked this pull request as ready for review March 15, 2024 17:50
@Stuyk Stuyk mentioned this pull request Mar 15, 2024
@clockworkgr
Copy link
Member

I think we should have Links as a separate tab to be honest. wdyt? @alexiscolin @Stuyk ?

@clockworkgr
Copy link
Member

clockworkgr commented Mar 18, 2024

Also, we are already doing the main data handling/processing in the ProposalView..

Having tabs as separate components altogether makes our lives somewhat difficult. We either have to reload / reprocess data or just prop-drill everything neither of which is ideal.

The tabs mechanism should be set up in such a way where we could have the following inside ProposalView:

<UITabs>
<UITab title="whatever">
our content components/data here
</UITab>
<UITab title="second tab">
our content components/data here
</UITab>
....
</UITabs>

@alexiscolin wdyt?

@Stuyk
Copy link
Collaborator Author

Stuyk commented Mar 18, 2024

Also, we are already doing the main data handling/processing in the ProposalView..

Having tabs as separate components altogether makes our lives somewhat difficult. We either have to reload / reprocess data or just prop-drill everything neither of which is ideal.

The tabs mechanism should be set up in such a way where we could have the following inside ProposalView:

<UITabs>
<UITab title="whatever">
our content components/data here
</UITab>
<UITab title="second tab">
our content components/data here
</UITab>
....
</UITabs>

@alexiscolin wdyt?

I'll decouple this and swap it to non-dynamic components

@Stuyk Stuyk changed the title feat: tabs with dynamic components feat: tabs for proposal page Mar 18, 2024
@clockworkgr clockworkgr merged commit 348c06e into main Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants