Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint test #10

Merged
merged 3 commits into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,21 @@
name: Linting

on:
pull_request_target:
types:
- opened
- edited
- synchronize


jobs:
lint:
name: Lint
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- uses: pnpm/action-setup@v2
with:
version: 8
Expand All @@ -22,7 +27,9 @@ jobs:
- name: Install dependencies
run: pnpm install
- name: Run eslint on changed files
uses: reviewdog/action-eslint@v1
uses: tj-actions/eslint-changed-files@v23
with:
reporter: github-pr-check
eslint_flags: " -c .eslintrc.js './src/**/*.ts' --max-warnings=0 --ignore-path .gitignore"
config_path: ".eslintrc.js"
ignore_path: ".gitignore"
file_extensions: './src/**/*.ts'
extra_args: "--max-warnings=0"
2 changes: 2 additions & 0 deletions .github/workflows/test-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- uses: pnpm/action-setup@v2
with:
version: 8
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test-vitest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ jobs:
name: Unit tests
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- uses: pnpm/action-setup@v2
with:
version: 8
Expand Down
2 changes: 1 addition & 1 deletion src/utils/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
.call(byteArray, function (byte) {
return ("0" + (byte & 0xff).toString(16)).slice(-2);
})
.join("");
.join("");

Check failure on line 6 in src/utils/index.ts

View workflow job for this annotation

GitHub Actions / eslint

[eslint] src/utils/index.ts#L6 <prettier/prettier>(https://github.com/prettier/eslint-plugin-prettier#options)

Delete `····`
Raw output
{"ruleId":"prettier/prettier","severity":2,"message":"Delete `····`","line":6,"column":5,"nodeType":null,"messageId":"delete","endLine":6,"endColumn":9,"fix":{"range":[198,202],"text":""}}
}
Loading