Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add browser testing support #13

Merged
merged 2 commits into from
Feb 7, 2024
Merged

chore: add browser testing support #13

merged 2 commits into from
Feb 7, 2024

Conversation

Stuyk
Copy link
Contributor

@Stuyk Stuyk commented Feb 6, 2024

Adds browser support to the library.

https://vitest.dev/guide/browser

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 92.85% / 50% 13 / 14
🟢 Statements 93.33% / 50% 14 / 15
🟢 Functions 100% / 50% 5 / 5
🟢 Branches 75% / 50% 3 / 4
File CoverageNo changed files found.
Generated in workflow #36

@clockworkgr
Copy link
Member

not sure if we're gonna have browser-specific stuff in this but doesn't hurt...

Whats the difference between the v8 and istanbul providers btw?

@Stuyk
Copy link
Contributor Author

Stuyk commented Feb 6, 2024

not sure if we're gonna have browser-specific stuff in this but doesn't hurt...

Whats the difference between the v8 and istanbul providers btw?

No idea but one works with ci and the other one does not. If we're meant to be using this in the browser we should probably add full browser coverage.

@Stuyk Stuyk merged commit b5c09bd into main Feb 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants