Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New topic case + handle window-related errorcodes #88

Merged
merged 2 commits into from
Nov 28, 2024
Merged

New topic case + handle window-related errorcodes #88

merged 2 commits into from
Nov 28, 2024

Conversation

xmariachi
Copy link
Collaborator

@xmariachi xmariachi commented Nov 27, 2024 •
edited
Loading

Purpose of Changes and their Description

  • Better handling of the new-topic case
  • Handles out-of-window reputer and worker ABCI code with exp retry

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed. -- tested locally against v0.7.0 rc chain
  • If documented, please describe where. If not, describe why docs are not needed. -- no need, just improved internal mechanism
  • Added to Unreleased section of CHANGELOG.md?

@xmariachi xmariachi changed the title New topic + handle window-related errorcodes New topic case + handle window-related errorcodes Nov 27, 2024
@xmariachi xmariachi marked this pull request as ready for review November 27, 2024 18:46
amimart
amimart approved these changes Nov 27, 2024
View reviewed changes
Copy link

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me :)

@kpeluso kpeluso merged commit 34c0c5f into dev Nov 28, 2024
3 checks passed
@kpeluso kpeluso deleted the diego/proto-2976-new-topic-issues-kickstart-deactivation branch November 28, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amimart amimart amimart approved these changes

@kpeluso kpeluso kpeluso approved these changes

@fernandofcampos fernandofcampos fernandofcampos approved these changes

@clementupshot clementupshot Awaiting requested review from clementupshot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xmariachi @fernandofcampos @kpeluso @amimart