Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Fred a betting master 🎲🎲🎲 #21

Closed
wants to merge 19 commits into from
Closed

Conversation

SammyIsra
Copy link
Collaborator

@SammyIsra SammyIsra commented May 21, 2020

Resolves #20

This will allow for rolls in two formats.

DnD style rolling:

fred roll [3d]50

Where

  • 3 would be the number of dice.
  • 50 is the sides of the dice.

WoW style rolling:

fred roll [1] [100]

Where

  • 1 would be the lower bound of the roll. Inclusive.
    • Optional. Default is 1.
  • 100 would be the upper bound of the roll. Inclusive.
    • Optional. Default is 100. If only one value is provided, it will be the upper bound.

The most minimal version of the roll in WoW style is

fred roll

Since every other value is optional.

There are a few checks in place to make sure that the math is safe, and the regex make sure that the values provided are all valid numbers.

Thank you Adam for the regex!

@SammyIsra SammyIsra requested a review from allygator May 21, 2020 07:36
@allygator allygator linked an issue May 24, 2020 that may be closed by this pull request
@SammyIsra SammyIsra self-assigned this Jul 19, 2020
@SammyIsra
Copy link
Collaborator Author

I may have messed up in rebasing into origin/master. Closing this and reopening with new branch.

@SammyIsra SammyIsra closed this Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fred roll X
2 participants