fix(build): avoid lto use without lld #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const is_macos = builtin.os.tag == .macos; | ||
| const is_windows = builtin.os.tag == .windows; | ||
| const use_lld = if (is_macos) false else if (is_windows) true else switch (optimize) { | ||
| .Debug => false, | ||
| else => true, | ||
| }; | ||
| const use_lto = if (is_macos) false else if (use_lld) lto else false; |
There was a problem hiding this comment.
Went back and forth on whether to keep is_macos here. Ended up keeping it so a reader does not need to keep the additional context in mind. But can nix it if wanted.
There was a problem hiding this comment.
I thought I was thorough but didn't catch this, Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on environment,
--lto=truewill result in anerror.LtoRequiresLld: "LTO requires using LLD"This occurs when
use_lldis false because zig ld does not support LTO yet: ziglang/zig#8680. So, without lld, we can't LTO.