Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main = file-dialog-min.js ? #5

Open
houshuang opened this issue Apr 8, 2017 · 1 comment
Open

main = file-dialog-min.js ? #5

houshuang opened this issue Apr 8, 2017 · 1 comment

Comments

@houshuang
Copy link

Hi,
thanks for making this module available. Would it make sense to link main to the minified file? I'm using this with Meteor, which supports Babel and import statements, but which expects libraries to be already transformed into ES5, so trying to build an app which includes this module fails at the uglify stage (because the code doesn't get run through Babel, even though my own code is ES6, and does get run through babel).

I guess eventually there might be a way to specify an ES5 and an ES6 main, since I understand that people using rollup etc want access to the unminified code...

@QuentinRoy
Copy link

QuentinRoy commented Aug 12, 2017

Probably not the minified version, however, I agree that the convention is that an npm package should be ES5 ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants