Accessibility fixes #3283
Merged
Accessibility fixes #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesCGDS
force-pushed
the
accessibility_fixes
branch
from
b05d6df
to
ec1a9d1
Compare
JamesCGDS
force-pushed
the
accessibility_fixes
branch
from
ec1a9d1
to
8159b95
Compare
JamesCGDS
force-pushed
the
accessibility_fixes
branch
from
8159b95
to
3e90a68
Compare
AshGDS
requested changes
Feb 16, 2024
JamesCGDS
force-pushed
the
accessibility_fixes
branch
from
f56b006
to
69559b5
Compare
|
Thanks for the review @AshGDS - should be ready for a re-review now |
AshGDS
reviewed
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes a bug where focus is lost on the "Sort by"
selectelement after using it to sort search results. This is because the DOM is updated with new elements when a user uses the "Sort by" filter. This includes inserting an entirely new "Sort by"selectelement and removing the previousselectelement which had received focus. I have applied a fix which retains the originalselectelement and only updates theoptionelements within, therefore retaining the focus on theselectelement after it's been used.This is achieved by using a regex on the new stringified HTML (
results.sort_options_markup) that is received whenupdateSortOptions()is run following the application of filters to extract theoptionelements. The newoptionelements then replace the existingoptionelements in the "Sort by"selectelement.Why
Identified as an issue as part of the WCAG audit of GOV.UK - trello card
Visual changes
None.