Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable document list component tracking in search #3290

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Disable document list component tracking in search #3290

merged 1 commit into from
Feb 23, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Feb 23, 2024

What

  • GA4 tracking was added to the document list component (gem version isn't released yet)
  • Disable it from being enabled in finder frontend

Why

  • Finder frontend uses this component for the search results
  • However the search results have their own eCommerce tracking, so we should disable the document list component tracking

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@AshGDS
Disable document list component tracking in search
6463c40 
The search uses eCommerce tracking, so disable the document list tracking
@AshGDS AshGDS self-assigned this Feb 23, 2024
@govuk-ci govuk-ci temporarily deployed to finder-frontend-pr-3290 February 23, 2024 10:39 Inactive
@AshGDS AshGDS merged commit 1b10089 into main Feb 23, 2024
15 checks passed
@AshGDS AshGDS deleted the ga4-disable-document-list-tracking branch February 23, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysellick andysellick andysellick approved these changes

Assignees

@AshGDS AshGDS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshGDS @andysellick @govuk-ci