Use v2 for all site search queries #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches the `/search/all` ("site search") finder over to use
`search-api-v2` exclusively now that our AB test has concluded with a
positive outcome.
- Instead of checking for AB test variant, check for site search finder
base path to establish whether to use v2
- Add `use_v1` query parameter along the lines of the existing `use_v2`
to force use of `search-api` in circumstances where `search-api-v2`
would normally be used
- Fix stubbing of API endpoints in tests
leenagupte
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the
/search/all("site search") finder over to usesearch-api-v2exclusively now that our AB test has concluded with a positive outcome.use_v1query parameter along the lines of the existinguse_v2to force use ofsearch-apiin circumstances wheresearch-api-v2would normally be used