Upgrade to govuk frontend 5.1.0 #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MartinJJones
force-pushed
the
upgrade-to-govuk-frontend-5.1.0
branch
from
5b8a7e0
to
795e329
Compare
MartinJJones
force-pushed
the
upgrade-to-govuk-frontend-5.1.0
branch
from
795e329
to
591dde3
Compare
MartinJJones
added
the
do-not-merge
MartinJJones
changed the title
andysellick
approved these changes
Jul 8, 2024
MartinJJones
force-pushed
the
upgrade-to-govuk-frontend-5.1.0
branch
from
591dde3
to
2a88393
Compare
To prevent browsers evaluating JS that isn't supported, components that contain code from govuk-frontend have been moved to a separate file `es6-components.js` which is included in `application.html.erb` as a script tag with `type="module"`.
- $govuk-new-link-styles is now set to true by default - The other SCSS variables are deprecated from v5 of govuk-frontend
Updated to continue to use the closest Polyfill from v4 of govuk-frontend which is now included in the publishing_components_gem
AshGDS
force-pushed
the
upgrade-to-govuk-frontend-5.1.0
branch
from
774896b
to
ab15234
Compare
AshGDS
changed the title
AshGDS
removed
the
do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
es6-components.jsfileWhy
Move components that rely on govuk-frontend modules to seperate
es6-components.jsfileIn the event that a browser below the target for
govuk-frontendloads a page with JS on it, attempting to parse the JS fromgovuk-frontendwill cause an error. To avoid this from happening, JS that containsgovuk-frontendJS has been moved to seperate file which will be loaded in a script tag withtype="module". This will prevent the JS from being parsed and so prevent the errorRemove Sass variables
$legacyattribute ingovuk-colourhas been deprecated and using it will have no effect (other than generating warnings on pre-compilation)$govuk-compatibility-govuktemplate$govuk-use-legacy-palette$govuk-typography-use-rem$govuk-new-link-stylesis now set totrueby default, so it does not need to be setUpdate polyfill file paths
Browser polyfills are no longer included in v5 of govuk-frontend, any Polyfills provided in v4 of govuk-frontend will be included in the new version of the govuk-publishing-components gem.
The intention is for this PR to include the bump to the govuk-frontend v5 version of the govuk-publishing-components gem, this will also fix the failing tests relating to the missing polyfill.
Trello
Follow these steps if you are doing a Rails upgrade.