Move case studies routes #4372

georges1996 · 2024-11-04T20:26:33Z

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

This PR #4379 needs to be merged in and this will need to be rebased to fix the case studies which have translations e.g https://www.gov.uk/government/case-studies/doing-business-in-spain

What

Handle Case Studies documents in Frontend, in preparation for them being taken out of Government Frontend

Why

Ticket: https://trello.com/c/ybpXwp34/368-move-document-type-casestudy-from-government-frontend-to-frontend

How

By moving the routes and necessary code to get the pages rendering in the frontend application

Screenshots?

Frontend

Gov-Frontend

KludgeKML · 2024-11-12T13:17:25Z

app/models/concerns/withdrawable.rb

+  def withdrawal_notice_title
+    "This #{withdrawal_notice_context.downcase} was withdrawn on #{withdrawal_notice_time}".html_safe
+  end
+
+  def withdrawal_notice_context
+    I18n.t("formats.#{schema_name}", count: 1, locale: :en)
+  end
+
+  def withdrawal_notice_time
+    ActionController::Base.helpers.tag.time(
+      english_display_date(withdrawal_notice["withdrawn_at"]),
+      datetime: withdrawal_notice["withdrawn_at"],
+    )
+  end
+
+  def english_display_date(timestamp, format = "%-d %B %Y")
+    I18n.l(Time.zone.parse(timestamp), format:, locale: :en) if timestamp
+  end


A bit suspicious of these presentational items being in a model concern, might be better as helpers?

Travel Advice and Guides need to know the withdrawn state too, but I've tackled it a bit differently by splitting out the model and presentational concerns:

model concern: 0dfd811

generic presenter: 0590ed7

travel advice presenter: 53ee7c3

I'm not completely happy with the approach I've taken either, so I think it would be good to have a discussion about this.

app/helpers/locale_helper.rb

app/models/content_item.rb

app/controllers/case_studies_controller.rb

app/presenters/case_studies_presenter.rb

KludgeKML · 2024-11-12T13:22:07Z

Looking good, a few inline comments to take care of.

app/views/case_studies/show.html.erb

Commit audit trail: - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/app/presenters/content_item/linkable.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/test/presenters/content_item/linkable_test.rb

Commit audit trail: - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/app/presenters/content_item/metadata.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/test/presenters/content_item/metadata_test.rb

Commit audit trail: - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/app/presenters/content_item/updatable.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/test/presenters/content_item/updatable_test.rb

Commit audit trail: - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/app/presenters/content_item/withdrawable.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/test/presenters/content_item/withdrawable_test.rb

…e studies Commit audit trail: - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/app/presenters/content_item_presenter.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/test/presenters/content_item_presenter_test.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/app/helpers/application_helper.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/test/helpers/application_helper_test.rb

- To use the Withdrawable concern - To expose first_published_at and first_public_at attributes

Commit audit trail: - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/app/views/shared/_publisher_metadata_with_logo.html.erb

Commit audit trail: - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/app/presenters/case_study_presenter.rb - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/app/views/content_items/case_study.html.erb - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/test/integration/case_study_test.rb - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/test/presenters/case_study_presenter_test.rb - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/config/routes.rb

Using govuk-docker-run rake "consolidation:copy_translation[content_item.schema_name.case_study]" we port over the case_study translations and change it to be under our new yaml structure Audit trail: - https://github.com/alphagov/government-frontend/tree/0aee348d51cebacd5344115f2ca02bdb17095249/config/locales

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 4, 2024 20:26 Inactive

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 4, 2024 20:28 Inactive

georges1996 changed the title ~~Move case studies documents~~ Move case studies routes Nov 4, 2024

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 4, 2024 20:38 Inactive

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 4, 2024 20:42 Inactive

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 4, 2024 20:54 Inactive

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 4, 2024 20:59 Inactive

georges1996 force-pushed the move-case-studies-pages branch from 4b79f76 to 5736b90 Compare November 4, 2024 21:01

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 4, 2024 21:01 Inactive

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 4, 2024 21:10 Inactive

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 4, 2024 21:13 Inactive

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 4, 2024 21:19 Inactive

georges1996 force-pushed the move-case-studies-pages branch from dbc0da6 to f4d9f5d Compare November 4, 2024 21:27

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 4, 2024 21:28 Inactive

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 5, 2024 07:11 Inactive

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 5, 2024 07:16 Inactive

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 5, 2024 07:23 Inactive

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 5, 2024 12:27 Inactive

georges1996 force-pushed the move-case-studies-pages branch from aee5af8 to 6d4592f Compare November 5, 2024 12:50

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 5, 2024 12:51 Inactive

georges1996 force-pushed the move-case-studies-pages branch from 6d4592f to 40db71b Compare November 5, 2024 13:03

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 5, 2024 13:04 Inactive

georges1996 force-pushed the move-case-studies-pages branch from 40db71b to a368c2c Compare November 5, 2024 13:15

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 5, 2024 13:15 Inactive

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 6, 2024 08:30 Inactive

govuk-ci had a problem deploying to govuk-frontend-app-pr-4372 November 6, 2024 08:36 Failure

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 6, 2024 08:46 Inactive

georges1996 force-pushed the move-case-studies-pages branch from e8d36b1 to 0d5579a Compare November 6, 2024 14:36

govuk-ci temporarily deployed to govuk-frontend-app-pr-4372 November 6, 2024 14:36 Inactive

georges1996 force-pushed the move-case-studies-pages branch from 0d5579a to dc0a31b Compare November 6, 2024 14:55