Swap Design System list for gem list on /help #4391
Merged
+24
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replace the GOV.UK Design System list component on
/help
with the gem list component.I would have liked to iterate through the list items to remove the repetition of tag and class names but we're currently storing the help link data as named values here and there might be a reason for making the values explicit to people editing the file. However, we've created a new card to look at the inconsistencies between the various gem and app level components that are used to render lists like this. Following on from that card we might be able to simplify how this specific list is rendered.
I've checked that the outputted HTML of the list is the same before and after including the href.
Why
We're moving to gem-level components in our frontend apps where possible to reduce frontend complexity.
Trello card
Screenshots?
Before
After