Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap Design System list for gem list on /help #4391

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

hannalaakso
Copy link
Member

@hannalaakso hannalaakso commented Nov 12, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Replace the GOV.UK Design System list component on /help with the gem list component.

I would have liked to iterate through the list items to remove the repetition of tag and class names but we're currently storing the help link data as named values here and there might be a reason for making the values explicit to people editing the file. However, we've created a new card to look at the inconsistencies between the various gem and app level components that are used to render lists like this. Following on from that card we might be able to simplify how this specific list is rendered.

I've checked that the outputted HTML of the list is the same before and after including the href.

Why

We're moving to gem-level components in our frontend apps where possible to reduce frontend complexity.

Trello card

Screenshots?

Before

before-help

After

after-help

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4391 November 12, 2024 18:55 Inactive
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, the changes look good to me, I've made a couple of small non-blocking comments that you may wish to look at further

app/views/help/index.html.erb Outdated Show resolved Hide resolved
app/views/help/index.html.erb Outdated Show resolved Hide resolved
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4391 November 13, 2024 15:06 Inactive
@hannalaakso hannalaakso merged commit 27f1a1f into main Nov 13, 2024
12 checks passed
@hannalaakso hannalaakso deleted the use-gem-list-on-help branch November 13, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants