Remove block options #4401
Remove block options #4401
Conversation
- some blocks have options, which are passed to them to control things like inverse and margin when they're inside other blocks - for example, all blocks within a hero block text box need to be inverse because the background colour is dark blue, otherwise the text would be unreadable - I came up with this system, but I now think it's confusing as blocks do 'magic' things to make them appear correctly and these things are effectively hard coded, removing control - so I'm removing this, and moving all the options into the YAML so they can be controlled from there - it makes the YAML a bit more verbose, but I think makes adding and configuring blocks clearer
|
@leenagupte does this PR seem sensible to you? Options seemed like a good idea at the time, but they're starting to get in the way, particularly in light of #4400 |
So reason that block options were added in the first place, is that everything that's configured in the blocks will appear in the content item. And it feels very odd to define such purely low-level presentational things like "margin-bottom" in the content item. It felt like the type of block should be able to handle this stuff. i.e. the block should be able to figure out the margin it needs based on information it has about itself. i.e. if it's minimal, or is a full-width block. |
What
Things to do:
Why
Visual changes
None, but we might need to update some of the data currently in draft otherwise the pages are going to have visual/layout problems.