Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove block options #4401

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove block options #4401

wants to merge 1 commit into from

Commits on Nov 15, 2024

  1. Remove block options

    - some blocks have options, which are passed to them to control things like inverse and margin when they're inside other blocks
    - for example, all blocks within a hero block text box need to be inverse because the background colour is dark blue, otherwise the text would be unreadable
    - I came up with this system, but I now think it's confusing as blocks do 'magic' things to make them appear correctly and these things are effectively hard coded, removing control
    - so I'm removing this, and moving all the options into the YAML so they can be controlled from there
    - it makes the YAML a bit more verbose, but I think makes adding and configuring blocks clearer
    andysellick committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f0af809 View commit details
    Browse the repository at this point in the history