Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of default category var #4136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joelanman
Copy link
Contributor

Earlier in the code a default category is set if one is not sent:

 {%- set category -%}
    {%- if params.category -%}
      {{ params.category }}
    {%- else -%}
      analytics
    {%- endif -%}
  {%- endset -%}

However later on the code refers to params.category - which could be null. If it is null the javascript breaks. This PR refers to category instead to make sure a value is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant