Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no need to use autocomplete in prototypes #4137

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

selfthinker
Copy link
Contributor

A user suggested:

On this page: https://design-system.service.gov.uk/components/date-input/

You say: “You will not normally need to use the autocomplete attribute in prototypes, as users will not generally be using their own devices.”
I’d like to suggest removing this because:

  • It might have been true once, but these days so much UR is done over video call
  • You’d particularly expect accessibility users to use their own devices with their own settings
  • Omitting this from prototypes might result in it also being missed out of final designs, as it means someone has to remember to put it back in

So would you consider deleting this?

I think that makes sense. I was thinking about rephrasing it, but there is no harm in removing it completely and more harm in having it there.

Copy link

netlify bot commented Sep 18, 2024

You can preview this change here:

Name Link
🔨 Latest commit 6975a66
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/66eae22c13656800083e2063
😎 Deploy Preview https://deploy-preview-4137--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@selfthinker selfthinker merged commit 43f24a2 into main Sep 18, 2024
15 checks passed
@selfthinker selfthinker deleted the autocomplete-in-prototypes branch September 18, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants