Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where UUIDs are expected change the type from String #241

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

willp-bl
Copy link
Contributor

What problem does the pull request solve?

Changes the external API to ensure that UUID are passed instead of a String

Checklist

  • I’ve used the pull request template
  • I’ve written unit tests for these changes
  • I’ve updated the documentation in
  • I’ve bumped the version number
    • in src/main/resources/application.properties
    • in pom.xml

@quis
Copy link
Member

quis commented Sep 16, 2024

Is the improvement this gives worth making a breaking change to service’s code? Do we think consumers are handling UUIDs as UUIDs in their code, or just strings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants