Set autocomplete attribute on input elements appropriately #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trello: https://trello.com/c/WHsgcFDz This explicitly sets the autocomplete attribute to "off" on all input elements unless there is a specificly suitable value, e.g. "name", "email", "current-password", "new-password" [1]. Note that these values must apply for the current user and not for another user, e.g. when a user is editing the details of another user, autocomplete should be set to "off" for the "name" & "email" fields. The original motivation behind this was that some password managers were filling in the "name" and "email" fields on the edit user page. This was because autocomplete was not set on the fields, the password manager heuristics decided that they were legitimate "name" & "email" fields, and (since there was only one matching item for the domain) the password manager filled the field with the current user's name and email address. This should no longer happen, because we are now setting autocomplete to "off" for those two fields. [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#values
floehopper
force-pushed
the
set-autocomplete-on-input-fields
branch
from
eda142d
to
57687ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/WHsgcFDz
This explicitly sets the autocomplete attribute to "off" on all input elements unless there is a specificly suitable value, e.g. "name", "email", "current-password", "new-password". Note that these values must apply for the current user and not for another user, e.g. when a user is editing the details of another user, autocomplete should be set to "off" for the "name" & "email" fields.
The original motivation behind this was that some password managers were filling in the "name" and "email" fields on the edit user page. This was because autocomplete was not set on the fields, the password manager heuristics decided that they were legitimate "name" & "email" fields, and (since there was only one matching item for the domain) the password manager filled the field with the current user's name and email address. This should no longer happen, because we are now setting autocomplete to "off" for those two fields.
I have manually tested all the affected pages in Firefox on MacOS.