Commits on Aug 9, 2023

1. Set autocomplete attribute on input elements appropriately …

   Trello: https://trello.com/c/WHsgcFDz
   
   This explicitly sets the autocomplete attribute to "off" on all input
   elements unless there is a specificly suitable value, e.g. "name",
   "email", "current-password", "new-password" [1]. Note that these values
   must apply for the current user and not for another user, e.g. when a
   user is editing the details of another user, autocomplete should be set
   to "off" for the "name" & "email" fields.
   
   The original motivation behind this was that some password managers were
   filling in the "name" and "email" fields on the edit user page. This was
   because autocomplete was not set on the fields, the password manager
   heuristics decided that they were legitimate "name" & "email" fields,
   and (since there was only one matching item for the domain) the password
   manager filled the field with the current user's name and email address.
   This should no longer happen, because we are now setting autocomplete to
   "off" for those two fields.
   
   [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#values

   

   floehopper committed Aug 9, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 57687ef
   • Browse repository at this point

   Copy the full SHA

   57687ef View commit details

   Browse the repository at this point in the history