Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump govuk_publishing_components from 35.15.4 to 35.16.0 #2368

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 20, 2023

Bumps govuk_publishing_components from 35.15.4 to 35.16.0.

Changelog

Sourced from govuk_publishing_components's changelog.

35.16.0

35.15.5

Commits
  • e02ea96 Merge pull request #3624 from alphagov/release-35.16.0
  • 33c68d3 Version 35.16.0
  • b53cdcd Merge pull request #3623 from alphagov/add-option-select
  • d8713ee Update changelog
  • 8340558 Fix styling issue with input filter
  • 9e7536b Fix incorrect margin
  • f5427e4 Merge pull request #3614 from alphagov/dependabot/npm_and_yarn/jasmine-browse...
  • ad7ef98 Bump jasmine-browser-runner from 2.2.0 to 2.3.0
  • 847137f Merge pull request #3607 from alphagov/dependabot/npm_and_yarn/axe-core-4.8.1
  • 783d79e Merge pull request #3608 from alphagov/dependabot/bundler/gds-api-adapters-91...
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
govuk_publishing_components [< 29.16, > 29.15.0]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Sep 20, 2023
@github-actions
Copy link

This application is owned by the Access & Permissions team.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 35.15.4 to 35.16.0.
- [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/main/CHANGELOG.md)
- [Commits](alphagov/govuk_publishing_components@v35.15.4...v35.16.0)

---
updated-dependencies:
- dependency-name: govuk_publishing_components
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@andysellick andysellick force-pushed the dependabot/bundler/govuk_publishing_components-35.16.0 branch from 8af0ea0 to ae703a4 Compare September 20, 2023 14:51
@andysellick andysellick force-pushed the dependabot/bundler/govuk_publishing_components-35.16.0 branch from ae703a4 to 354156d Compare September 20, 2023 14:53
Copy link

@jon-kirwan jon-kirwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me. There's a small-ish visual difference, due to the addition of margin: 0; on thegem-c-option-select__heading, with the new changes but not sure how much of an issue it is (personally I think it's improved).

enabled .gem-c-option-select__heading {
    position: relative;
    padding: 10px 8px 5px 43px;
    /* margin: 0; */
}

@andysellick
Copy link
Contributor

Thanks @jon-kirwan. Good spot on the margin, this was also noticed in the gem PR by @MartinJJones - it turns out that the component (when it was in finder-frontend) was inadvertently relying on a CSS reset in that application, which removed the margin on that heading element. When it got copied into signon it looks like this was overlooked, hence the discrepancy now that the margin has been manually removed in the gem stylesheet.

@floehopper floehopper self-assigned this Sep 21, 2023
@floehopper floehopper self-requested a review September 21, 2023 09:16
Copy link
Contributor

@floehopper floehopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - many thanks for working on it! 👍

@andysellick andysellick merged commit 30adfd0 into main Sep 21, 2023
6 checks passed
@andysellick andysellick deleted the dependabot/bundler/govuk_publishing_components-35.16.0 branch September 21, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants