-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump govuk_publishing_components from 35.15.4 to 35.16.0 #2368
Bump govuk_publishing_components from 35.15.4 to 35.16.0 #2368
Conversation
This application is owned by the Access & Permissions team. Follow these steps if you are doing a Rails upgrade. |
Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 35.15.4 to 35.16.0. - [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/main/CHANGELOG.md) - [Commits](alphagov/govuk_publishing_components@v35.15.4...v35.16.0) --- updated-dependencies: - dependency-name: govuk_publishing_components dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
8af0ea0
to
ae703a4
Compare
ae703a4
to
354156d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine to me. There's a small-ish visual difference, due to the addition of margin: 0;
on thegem-c-option-select__heading
, with the new changes but not sure how much of an issue it is (personally I think it's improved).
enabled .gem-c-option-select__heading {
position: relative;
padding: 10px 8px 5px 43px;
/* margin: 0; */
}
Thanks @jon-kirwan. Good spot on the margin, this was also noticed in the gem PR by @MartinJJones - it turns out that the component (when it was in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - many thanks for working on it! 👍
Bumps govuk_publishing_components from 35.15.4 to 35.16.0.
Changelog
Sourced from govuk_publishing_components's changelog.
Commits
e02ea96
Merge pull request #3624 from alphagov/release-35.16.033c68d3
Version 35.16.0b53cdcd
Merge pull request #3623 from alphagov/add-option-selectd8713ee
Update changelog8340558
Fix styling issue with input filter9e7536b
Fix incorrect marginf5427e4
Merge pull request #3614 from alphagov/dependabot/npm_and_yarn/jasmine-browse...ad7ef98
Bump jasmine-browser-runner from 2.2.0 to 2.3.0847137f
Merge pull request #3607 from alphagov/dependabot/npm_and_yarn/axe-core-4.8.1783d79e
Merge pull request #3608 from alphagov/dependabot/bundler/gds-api-adapters-91...Most Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)