Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copy-paste mishap in test setup #2372

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix copy-paste mishap in test setup #2372

merged 1 commit into from
Sep 25, 2023

Conversation

mike29736
Copy link
Contributor

@mike29736 mike29736 commented Sep 22, 2023 •
edited
Loading

It was testing the wrong thing, now it's testing the right thing

@mike29736
Fix copy-paste mishap in test setup
42f9a64 
It's testing the wrong thing
@floehopper floehopper self-requested a review September 25, 2023 08:31
floehopper
floehopper approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@floehopper floehopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This looks good to me, although there's a typo in the commit note which makes it a bit confusing!

not it's testing the right thing

I assume "not" -> "now".

@mike29736 mike29736 merged commit 15ca127 into main Sep 25, 2023
7 checks passed
@mike29736 mike29736 deleted the fix-copy-paste-mishap branch September 25, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floehopper floehopper floehopper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike29736 @floehopper