Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Dependabot to update all RubyGems #2382

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

chrisroos
Copy link
Contributor

By default Dependabot only monitors direct dependencies (those specified in the Gemfile) for updates. It appears to use bundle update <dependency> under the hood, which means that a Dependabot PR to update <dependency> can also include updates to sub-dependencies. This makes it harder to review because the PR will only include the Changelog of <dependency> and not of the sub-dependencies.

My hope is that by configuring Dependabot to monitor direct and indirect (sub) dependencies1 we'll end up with more, smaller/easier to review, PRs.

By default Dependabot only monitors direct dependencies (those specified
in the Gemfile) for updates. It appears to use `bundle update
<dependency>` under the hood, which means that a Dependabot PR to update
<dependency> can also include updates to sub-dependencies. This makes it
harder to review because the PR will only include the Changelog of
<dependency> and not of the sub-dependencies.

My hope is that by configuring Dependabot to monitor direct and indirect
(sub) dependencies[1] we'll end up with more, smaller/easier to review,
PRs.

[1]: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#allow
@floehopper floehopper self-assigned this Sep 28, 2023
@floehopper floehopper self-requested a review September 28, 2023 10:18
Copy link
Contributor

@floehopper floehopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like it's worth a try 👍

@chrisroos chrisroos merged commit 24dac7f into main Sep 28, 2023
7 checks passed
@chrisroos chrisroos deleted the update-dependabot-config branch September 28, 2023 10:24
chrisroos added a commit to alphagov/authenticating-proxy that referenced this pull request Nov 16, 2023
By default Dependabot only monitors direct dependencies (those specified
in the Gemfile) for updates. It appears to use `bundle update
<dependency>` under the hood, which means that a Dependabot PR to update
<dependency> can also include updates to sub-dependencies. This makes it
harder to review because the PR will only include the Changelog of
<dependency> and not of the sub-dependencies.

My hope is that by configuring Dependabot to monitor direct and indirect
(sub) dependencies[1] we'll end up with more, smaller/easier to review,
PRs.

I think the same change[2] has been working reasonably well in Signon and
thought it was worth bringing authenticating-proxy into line.

[1]: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#allow
[2]: alphagov/signon#2382
chrisroos added a commit to alphagov/gds-sso that referenced this pull request Nov 16, 2023
By default Dependabot only monitors direct dependencies (those specified
in the Gemfile) for updates. It appears to use `bundle update
<dependency>` under the hood, which means that a Dependabot PR to update
<dependency> can also include updates to sub-dependencies. This makes it
harder to review because the PR will only include the Changelog of
<dependency> and not of the sub-dependencies.

My hope is that by configuring Dependabot to monitor direct and indirect
(sub) dependencies[1] we'll end up with more, smaller/easier to review,
PRs.

I think the same change[2] has been working reasonably well in Signon
and thought it was worth bringing gds-sso into line.

[1]: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#allow
[2]: alphagov/signon#2382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants