Improve organisation select on role organisations page #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislo
force-pushed
the
improve-organisation-select-on-role-organisations-page
branch
from
3ef31be
to
209611b
Compare
floehopper
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
This all looks good to me, but I've added a bunch of subjective comments. I'm happy to leave you to decide whether/how to address them, so I'll mark this as approved.
One thing it might be worth changing is the "Sort organisation options alphabetically by name (with abbreviation)" commit subject line. From what I can tell the sorting is by name and not abbreviation. If that's correct, I found "(with abbreviation)" bit of the commit title confusing!
|
I'm going to rebase the fixup comments and make the change @floehopper suggested to the commit title. |
We want to improve these options by sorting alphabetically and excluding closed organisations. First let's extract a helper method and add some tests for the existing behaviour.
This hopefully makes it easier for users to find the organisation they are looking for in the (long) list of options.
We don't want to assign users to closed organisations so it doesn't make sense to include them in the select list.
chrislo
force-pushed
the
improve-organisation-select-on-role-organisations-page
branch
from
44bba6a
to
924e00c
Compare
chrislo
deleted the
improve-organisation-select-on-role-organisations-page
branch
chrislo
added a commit
that referenced
this pull request
Oct 11, 2023
This makes it easier to select the organisation for a batch of users by excluding closed organisations and sorting the remaining ones alphabetically. We did something similar in #2426 and #2417 - there's enough subtle differences in those two select boxes (indicating a current organisation and adding a "None" option respectively) that I haven't attempted to extract the duplication. I think the new scopes are self-explanatory enough that I'm happy to keep them inline in this view.
chrislo
added a commit
that referenced
this pull request
Oct 11, 2023
This makes it easier to select the organisation for a batch of users by excluding closed organisations and sorting the remaining ones alphabetically. We did something similar in #2426 and #2417 - there's enough subtle differences in those two select boxes (indicating a current organisation and adding a "None" option respectively) that I haven't attempted to extract the duplication. I think the new scopes are self-explanatory enough that I'm happy to keep them inline in this view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/R9bKDyi5
The current "Your Organisation" dropdown on
/account/role_organisationis hard to navigate. This PR improves things a bit by excluding closed organisations from the list and sorting the organisations alphabetically by name.