Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve organisation select on role organisations page #2417

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Improve organisation select on role organisations page #2417

merged 4 commits into from
Oct 10, 2023

Commits on Oct 10, 2023

  1. Extract options_for_organisation_select helper 

    We want to improve these options by sorting alphabetically and
excluding closed organisations. First let's extract a helper method
and add some tests for the existing behaviour.
    @chrislo
    chrislo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c051bf6 View commit details
    Browse the repository at this point in the history

  2. Sort organisation options alphabetically by name 

    This hopefully makes it easier for users to find the organisation they
are looking for in the (long) list of options.
    @chrislo
    chrislo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    e37e5d9 View commit details
    Browse the repository at this point in the history

  3. Exclude closed organisations from the organisation select 

    We don't want to assign users to closed organisations so it doesn't
make sense to include them in the select list.
    @chrislo
    chrislo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    e7dd6c5 View commit details
    Browse the repository at this point in the history

  4. Extract Organisation#not_closed scope

    @chrislo
    chrislo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    924e00c View commit details
    Browse the repository at this point in the history