Use table component on API users application index #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floehopper
approved these changes
Jan 10, 2024
|
Oh, I just noticed the change in size of the table heading/caption. Is that consistent with what we've got elsewhere...? |
Yes, I think so - we're using the caption option for the table component in several other places in the code. |
I want to convert this table to use the table component. Extracting this helper first will make that easier.
This ensures the markup generated reflects the latest changes in the design system. I've decided to retain the `govuk-visually-hidden` Permissions header and to display an empty cell for the update permissions link, rather than the "Not set" default[1] when no link is required. [1] https://github.com/alphagov/govuk_publishing_components/blob/1df657ae5483552cf735396174c38eed134ba433/spec/components/table_spec.rb#L47
chrislo
force-pushed
the
use-table-component-on-api-users-application-index
branch
from
c527c8b
to
d561fd7
Compare
chrislo
deleted the
use-table-component-on-api-users-application-index
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/wSKG73MP
Arises from: #2599
To ensure we keep up with changes to the design system this PR replaces the table markup on
/app/views/api_users/applications/index.html.erbwith thetabledesign system component.Before
After