Improve consistency of breadcrumbs #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used a mixture of "Home" and "Dashboard" in our breadcrumbs, this makes sure they all start at "Dashboard".
chrislo
force-pushed
the
tidy-up-breadcrumbs
branch
2 times, most recently
from
feec20e
to
6af980e
Compare
As per the design system[1], the "breadcrumbs should start with your ‘home’ page and end with the parent section of the current page". This commit removes the current page from all of our breadcrumbs. [1] https://design-system.service.gov.uk/components/breadcrumbs/#how-it-works
chrislo
force-pushed
the
tidy-up-breadcrumbs
branch
from
6af980e
to
08081a3
Compare
The breadcrumb trail on this page only has a single link back to
Dashboard, and that link is easily accessible from the main nav. The
design system says[1]:
If you’re using other navigational elements on the page, such as a
sidebar, consider whether your users need the additional support
of breadcrumbs.
So I don't think we need this breadcrumb trail here.
[1] https://design-system.service.gov.uk/components/breadcrumbs/#how-it-works
The breadcrumb trail on this page only has a single link back to
Dashboard, and that link is easily accessible from the main nav. The
design system says[1]:
If you’re using other navigational elements on the page, such as a
sidebar, consider whether your users need the additional support
of breadcrumbs.
So I don't think we need this breadcrumb trail here.
[1] https://design-system.service.gov.uk/components/breadcrumbs/#how-it-works
We're not consistently using quotes around names in titles, so have decided to remove them.
We're not consistently using quotes around names in titles, so have decided to remove them.
We're not consistently using quotes around names in titles, so have decided to remove them.
Using a breadcrumb trail here is more consistent with the rest of the site.
This commit changes the last breadcrumb to match that used on `/users/*/applications`.
We don't think it's necessary to repeat the user's name in this breadcrumb trail and it can lead to very long breadcrumbs when the user has a long name.
We don't think it's necessary to repeat the user's name in this breadcrumb trail and it can lead to very long breadcrumbs when the user has a long name.
We don't think it's necesarry to include the word "Edit" in the title here, since the subtitle "Manage API users" conveys that information.
We don't think it's necesarry to include the word "Edit" in the title here, since the subtitle "Manage other users" conveys that information.
The other pages that are linked to from the /users/edit page have this title caption, so we should be consistent here too.
chrislo
force-pushed
the
tidy-up-breadcrumbs
branch
from
08081a3
to
079495d
Compare
floehopper
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/dB0VDo9a
We've taken a look at the site as a whole and identified some places where the consistency of the breadcrumb trail can be improved. The main changes here are in the first two commits where we:
The other changes are mostly small tweaks to make things more consistent.