Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rails from 7.0.8 to 7.1.3 #2653

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 17, 2024

Bumps rails from 7.0.8 to 7.1.3.

Release notes

Sourced from rails's releases.

7.1.3

Active Support

  • Handle nil backtrace_locations in ActiveSupport::SyntaxErrorProxy.

    Eugene Kenny

  • Fix ActiveSupport::JSON.encode to prevent duplicate keys.

    If the same key exist in both String and Symbol form it could lead to the same key being emitted twice.

    Manish Sharma

  • Fix ActiveSupport::Cache::Store#read_multi when using a cache namespace and local cache strategy.

    Mark Oleson

  • Fix Time.now/DateTime.now/Date.today to return results in a system timezone after #travel_to.

    There is a bug in the current implementation of #travel_to: it remembers a timezone of its argument, and all stubbed methods start returning results in that remembered timezone. However, the expected behaviour is to return results in a system timezone.

    Aleksei Chernenkov

  • Fix :unless_exist option for MemoryStore#write (et al) when using a cache namespace.

    S. Brent Faulkner

  • Fix ActiveSupport::Deprecation to handle blaming generated code.

    Jean Boussier, fatkodima

Active Model

  • No changes.

Active Record

  • Fix Migrations with versions older than 7.1 validating options given to add_reference.

... (truncated)

Commits
  • 36c1591 Preparing for 7.1.3 release
  • a84622f Sync changelog
  • 1f505f0 Merge pull request #50771 from rails/backport-preview-nplus1
  • d8a8dd9 Merge pull request #50758 from rails/fix-video-preview-nplus1
  • a0eef52 Merge pull request #50767 from rporrasluc/fix-db-runtime-calculation
  • 8a0767d Fix test setup to raise SyntaxError on Ruby 2.7
  • 894f933 Merge pull request #50764 from eugeneius/syntax_error_proxy_nil_backtrace_loc...
  • b02f6c9 Merge pull request #48957 from cmaruz/48326
  • c1e8b36 Merge pull request #50466 from skipkayhil/hm-fix-to-symbol-raising-nomethoderror
  • 16cd025 Add CHANGELOG entry for ee70ff4
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Jan 17, 2024
Copy link

This application is owned by the Access & Permissions team.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@dependabot dependabot bot force-pushed the dependabot/bundler/rails-7.1.3 branch 3 times, most recently from 714ad3c to 70504b8 Compare January 24, 2024 13:25
@dependabot dependabot bot force-pushed the dependabot/bundler/rails-7.1.3 branch 4 times, most recently from 11ff527 to 03286d7 Compare February 1, 2024 10:33
@dependabot dependabot bot force-pushed the dependabot/bundler/rails-7.1.3 branch 4 times, most recently from 3c1799f to 6dc6573 Compare February 13, 2024 15:02
@floehopper floehopper self-assigned this Feb 14, 2024
Bumps [rails](https://github.com/rails/rails) from 7.0.8 to 7.1.3.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v7.0.8...v7.1.3)

---
updated-dependencies:
- dependency-name: rails
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/rails-7.1.3 branch from 6dc6573 to 1bbe53f Compare February 15, 2024 15:54
@floehopper
Copy link
Contributor

I started work on this, but didn't get anywhere near completing it. However, I made the following notes which might be useful to someone taking this on:

@floehopper
Copy link
Contributor

It's worth noting that this app currently still uses Rails UJS in a few places (e.g. here). However, Turbo became the default solution in Rails v7.0 and I believe Rails UJS was deprecated at that point. It's unclear at what point Rails UJS will stop working, although it seems as if the @rails/ujs package was definitely removed in Rails v7.2.

I'm not certain whether the existing UJS links are all actually tested, so it'd be worth watching out for that.

Anyway, at some point someone will need to decide whether to migrate the existing usages to use Turbo or (probably more sensibly) convert the UI to use a fuller conventional HTML form without JS.

cc @chrislo @chrisroos @JonathanHallam @jkempster34

@jkempster34 jkempster34 marked this pull request as draft February 22, 2024 11:21
@jkempster34
Copy link
Contributor

Created a card for this and converted it to draft so that it doesn't get picked up by Dependapanda

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 22, 2024

Superseded by #2733.

@dependabot dependabot bot closed this Feb 22, 2024
@dependabot dependabot bot deleted the dependabot/bundler/rails-7.1.3 branch February 22, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants