-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rails from 7.0.8 to 7.1.3 #2653
Conversation
This application is owned by the Access & Permissions team. Follow these steps if you are doing a Rails upgrade. |
714ad3c
to
70504b8
Compare
11ff527
to
03286d7
Compare
3c1799f
to
6dc6573
Compare
Bumps [rails](https://github.com/rails/rails) from 7.0.8 to 7.1.3. - [Release notes](https://github.com/rails/rails/releases) - [Commits](rails/rails@v7.0.8...v7.1.3) --- updated-dependencies: - dependency-name: rails dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
6dc6573
to
1bbe53f
Compare
I started work on this, but didn't get anywhere near completing it. However, I made the following notes which might be useful to someone taking this on:
|
It's worth noting that this app currently still uses Rails UJS in a few places (e.g. here). However, Turbo became the default solution in Rails v7.0 and I believe Rails UJS was deprecated at that point. It's unclear at what point Rails UJS will stop working, although it seems as if the I'm not certain whether the existing UJS links are all actually tested, so it'd be worth watching out for that. Anyway, at some point someone will need to decide whether to migrate the existing usages to use Turbo or (probably more sensibly) convert the UI to use a fuller conventional HTML form without JS. |
Created a card for this and converted it to draft so that it doesn't get picked up by Dependapanda |
Superseded by #2733. |
Bumps rails from 7.0.8 to 7.1.3.
Release notes
Sourced from rails's releases.
... (truncated)
Commits
36c1591
Preparing for 7.1.3 releasea84622f
Sync changelog1f505f0
Merge pull request #50771 from rails/backport-preview-nplus1d8a8dd9
Merge pull request #50758 from rails/fix-video-preview-nplus1a0eef52
Merge pull request #50767 from rporrasluc/fix-db-runtime-calculation8a0767d
Fix test setup to raise SyntaxError on Ruby 2.7894f933
Merge pull request #50764 from eugeneius/syntax_error_proxy_nil_backtrace_loc...b02f6c9
Merge pull request #48957 from cmaruz/48326c1e8b36
Merge pull request #50466 from skipkayhil/hm-fix-to-symbol-raising-nomethoderror16cd025
Add CHANGELOG entry for ee70ff4You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)