Remove duplication in pundit policies #2665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisroos
force-pushed
the
remove-duplication-in-pundit-policies
branch
11 times, most recently
from
1f1f612
to
006a3c8
Compare
This was only being used to order them but we now hardcode the order.
We don't make use of User.role_classes so let's remove it.
We don't make use of User.roles so let's remove it.
As this is the only place it's used.
This is not used as User.admin_role_classes
These should not be necessary now that we reference the classes directly from the Roles module.
Have to fallback to `false` in `invitee_requires_2sv` to prevent a database constraint violation attempting to insert `null` into `require_2sv`.
No longer used.
chrisroos
force-pushed
the
remove-duplication-in-pundit-policies
branch
from
006a3c8
to
f9035b4
Compare
|
I ended up reworking this in #2670. That PR has been merged so this branch is no longer necessary. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This application is owned by the Access & Permissions team.
Follow these steps if you are doing a Rails upgrade.