Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibility statement for signon #2676

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

CristinaRO
Copy link
Contributor

@CristinaRO CristinaRO commented Feb 1, 2024

Trello

Screenshots of UI changes

Screenshot 2024-02-01 at 16 32 08 Screenshot 2024-02-01 at 16 32 18 Screenshot 2024-02-01 at 16 32 25 Screenshot 2024-02-01 at 16 32 34

Copy link
Contributor

@chrislo chrislo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @CristinaRO! Could you add a screenshot of the new page to the PR description? This helps team members who don't have a development environment set up to more easily check/understand the changes (when they result in end-user visable changes).

@CristinaRO
Copy link
Contributor Author

This looks good to me @CristinaRO! Could you add a screenshot of the new page to the PR description? This helps team members who don't have a development environment set up to more easily check/understand the changes (when they result in end-user visable changes).

Could we add an item asking for screenshots of any visual changes to the PR template please?

@chrislo
Copy link
Contributor

chrislo commented Feb 1, 2024

This looks good to me @CristinaRO! Could you add a screenshot of the new page to the PR description? This helps team members who don't have a development environment set up to more easily check/understand the changes (when they result in end-user visable changes).

Could we add an item asking for screenshots of any visual changes to the PR template please?

It's not always needed, so I don't think it's necessary to add it to the template. It's more of a team convention - you can check some of the recent PRs to this repo to get a feel for how we currently do things.

@chrislo chrislo merged commit d15525b into main Feb 5, 2024
17 checks passed
@chrislo chrislo deleted the 402-add-our-accessibility-statement-to-signon branch February 5, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants